Skip to content

feat: Add Xs3Conversion algo with JUnit tests #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

Tanmay-Singh3004
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (6682c7c) to head (4897c67).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5743      +/-   ##
============================================
+ Coverage     63.96%   64.01%   +0.05%     
- Complexity     4172     4176       +4     
============================================
  Files           583      584       +1     
  Lines         16320    16338      +18     
  Branches       3150     3152       +2     
============================================
+ Hits          10439    10459      +20     
+ Misses         5456     5455       -1     
+ Partials        425      424       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tanmay-Singh3004 Tanmay-Singh3004 marked this pull request as ready for review October 12, 2024 21:18
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Tanmay-Singh3004
Copy link
Contributor Author

@siriak , Thanks !
I first thought of adding this to the BcdConversion.java file, since the conversion to Excess-3 is almost similar to the Bcd conversion algorithm.

@siriak siriak merged commit 6af7f7b into TheAlgorithms:master Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants